Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context to 'too many segments' error in decoder. #431

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Add context to 'too many segments' error in decoder. #431

merged 2 commits into from
Feb 4, 2023

Conversation

lthibault
Copy link
Collaborator

Adds maximum observed segment ID and max segments for the given stream to error returned by decoder.

@lthibault lthibault requested a review from zenhack January 15, 2023 21:16
zenhack
zenhack reviewed Jan 15, 2023
View reviewed changes
message.go Outdated Show resolved Hide resolved
@lthibault lthibault requested a review from zenhack February 4, 2023 02:27
@lthibault lthibault self-assigned this Feb 4, 2023
@lthibault lthibault merged commit e9a1ca6 into main Feb 4, 2023
@lthibault lthibault deleted the improve-maxseg-error branch February 4, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenhack zenhack zenhack approved these changes

Assignees

@lthibault lthibault

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lthibault @zenhack