Avoid use of fmt in the main package. #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a String() method to ClientHook so we can avoid using fmt for that, then removes the last use of fmt in the main package, per capnproto#364. Before closing that issue, I think I'd still like to get it out of the flowcontrol package hierarchy at least, and maybe elsewhere if practical.
|
I was mistaken, there is at least one more use of fmt in the main package (in list.go) |
|
Test failures were because I forgot to add a String() for dummyHook; fixed. |
...so it implements ClientHook again.
|
Added another commit that removes the dep from flowcontrol as well. |
|
...apparently I'm bad at remembering to test before pushing today. Fixed. |
lthibault
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a String() method to ClientHook so we can avoid using fmt for that, then removes the last use of fmt in the main package, per #364.
Before closing that issue, I think I'd still like to get it out of the flowcontrol package hierarchy at least, and maybe elsewhere if practical.