Decode the file content properly. (#29)

caponetto · Aug 21, 2021 · c2f8414 · c2f8414
1 parent 53a1011
commit c2f8414
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -12,8 +12,8 @@
     {
       "name": "Launch vscode-extension (web)",
       "type": "pwa-extensionHost",
-      "debugWebWorkerHost": true,
       "request": "launch",
+      "runtimeExecutable": "${execPath}",
       "args": ["--extensionDevelopmentPath=${workspaceFolder}", "--extensionDevelopmentKind=web"],
       "outFiles": ["${workspaceRoot}/dist/**/*.js"],
     }

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 1.1.10
+Decode the file content properly
+
 # 1.1.9
 Add support for *.patch files
 

diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "vscode-diff-viewer",
   "displayName": "Diff Viewer",
   "description": "Visualize git diff files in VS Code",
-  "version": "1.1.9",
+  "version": "1.1.10",
   "license": "MIT",
   "publisher": "caponetto",
   "repository": {

diff --git a/src/DiffDocument.ts b/src/DiffDocument.ts
@@ -3,6 +3,7 @@ import * as vscode from "vscode";
 
 export class DiffDocument implements vscode.CustomDocument {
   private readonly _onDidDispose = new vscode.EventEmitter<void>();
+  private static readonly decoder = new TextDecoder("utf-8");
   public readonly onDidDispose = this._onDidDispose.event;
 
   get filename(): string {
@@ -18,6 +19,6 @@ export class DiffDocument implements vscode.CustomDocument {
 
   public static async create(uri: vscode.Uri): Promise<DiffDocument | PromiseLike<DiffDocument>> {
     const fileData = await vscode.workspace.fs.readFile(uri);
-    return new DiffDocument(uri, fileData.toString());
+    return new DiffDocument(uri, this.decoder.decode(fileData));
   }
 }