Adding RISCV to supported architectures #83
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s immediate operands
2 tasks
47 tasks
Rot127
requested changes
Aug 25, 2025
Comment on lines
+776
to
+778
| if (!(B < E)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Just add a comment so we don't forget about it.
There was a problem hiding this comment.
I think the //HACK! one is enough? you mean another comment?
Comment on lines
+963
to
+977
| patchSTIObject(TargetName, PatchedCode); | ||
|
|
||
| patchAddOperandGetOperand(TargetName, PatchedCode); | ||
| patchIsGetOperand(TargetName, PatchedCode); // must be after patchAddOperandGetOperand | ||
| patchAddOperandCreateOperand(TargetName, PatchedCode); | ||
|
|
||
| patchRegClassContains(TargetName, PatchedCode); | ||
|
|
||
| patchSetLoc(TargetName, PatchedCode); | ||
| patchEvaluateAsConstantImm(TargetName, PatchedCode); | ||
|
|
||
| patchSetOpcode(TargetName, PatchedCode); | ||
| patchGetOpcode(TargetName, PatchedCode); | ||
| patchIsBareSymbolRef(TargetName, PatchedCode); | ||
| patchIsUintIsShiftedUInt(TargetName, PatchedCode); |
There was a problem hiding this comment.
Better wrap this into a the TargetName == "RSICV" block.
Just in case the regex matches something else and other archs break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP to add RISCV support and fixes to LLVM so that the Capstone RISCV module is
Auto-Syncable. This is in support of capstone-engine/capstone#2756