Skip to content

Make build.rs compatible with Bazel's sandbox #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexDenisov
Copy link

@AlexDenisov AlexDenisov commented May 14, 2025

When building with Bazel's sandbox, all the capstone source files are actually symlinks. In this case build.rs doesn't find any files to build and attempts to link the static library right away.

Reproducer and the error messages can be found here.
I tested the change locally on macOS with the following spec:

crate.spec(
    package = "capstone-sys",
    git = "https://github.com/AlexDenisov/capstone-rs.git",
    branch = "bazel-compatibility",
)

which is working as expected.

Is there anything else I'd need to check to ensure this change doesn't break anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant