Skip to content

Commit

Permalink
Remove steps to verify the same google auth client is created by merl…
Browse files Browse the repository at this point in the history
…in and mlp
  • Loading branch information
deadlycoconuts committed Mar 14, 2024
1 parent 4c53078 commit d154503
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions api/turing/service/mlp_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (

//nolint:all
"bou.ke/monkey"
"github.com/caraml-dev/mlp/api/pkg/auth"
"github.com/patrickmn/go-cache"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -67,9 +66,6 @@ func TestNewMLPService(t *testing.T) {
reset := testSetupEnvForGoogleCredentials(t)
defer reset()

// Create test Google client
gc, err := auth.InitGoogleClient(context.Background())
require.NoError(t, err)
// Create test projects and environments
projects := []mlp.Project{{ID: 1}}
environments := []merlin.Environment{{Name: "dev"}}
Expand All @@ -78,7 +74,6 @@ func TestNewMLPService(t *testing.T) {
defer monkey.UnpatchAll()
monkey.Patch(newMerlinClient,
func(googleClient *http.Client, basePath string) *merlinClient {
assert.Equal(t, gc, googleClient)
assert.Equal(t, "merlin-base-path", basePath)
// Create test client
merlinClient := &merlinClient{
Expand All @@ -104,7 +99,6 @@ func TestNewMLPService(t *testing.T) {
)
monkey.Patch(newMLPClient,
func(googleClient *http.Client, basePath string) *mlpClient {
assert.Equal(t, gc, googleClient)
assert.Equal(t, "mlp-base-path", basePath)
// Create test client
mlpClient := &mlpClient{
Expand Down

0 comments on commit d154503

Please sign in to comment.