chore(api): Remove authz middleware and update Turing API server, router, plugin dependencies #371

deadlycoconuts · 2024-03-12T04:37:44Z

Context

Similar to caraml-dev/merlin#551, this MR basically bumps a couple of Go package dependencies used by the Turing API server, router, plugin, etc. The version of Go used in these components have also been bumped up from 1.20 to 1.22.

In addition to the general dependency upgrades, the authz middleware has been removed from the Turing API server entirely as it is no longer in use.

Main packages updated:

- github.com/GoogleCloudPlatform/spark-on-k8s-operator
- github.com/caraml-dev/mlp
- github.com/google/go-containerregistry 
- github.com/onsi/ginkgo/v2
- github.com/onsi/gomega
- k8s.io/api 
- k8s.io/apimachinery
- k8s.io/client-go
- knative.dev/networking
- knative.dev/pkg
- knative.dev/serving
- sigs.k8s.io/controller-runtime

Some minor refactoring was performed on structs that may have changed or on functions called due to the changes in their expected arguments - these are annotated directly on the diffs.

…idation file

…in and mlp

…ries

.github/workflows/turing.yaml

api/Makefile

api/e2e/test/router_e2e_test.go

api/e2e/test/cluster/cluster.go

api/turing/api/appcontext.go

api/turing/cluster/knative_service_test.go

api/turing/cluster/pvc.go

api/turing/cluster/virtual_service.go

api/turing/imagebuilder/imagebuilder.go

api/turing/service/mlp_service.go

engines/router/missionctl/internal/safe_chan.go

api/turing/middleware/openapi_validation.go

api/turing/cluster/virtual_service_test.go

api/turing/cluster/controller_test.go

api/turing/service/mlp_service_test.go

api/e2e/test/router_test.go

api/turing/cluster/controller.go

leonlnj

thanks for the heavy refactoring, left some minor comment but LGTM

…m arguments

leonlnj

thanks LGTM

deadlycoconuts · 2024-04-15T03:19:31Z

Thanks for the re-review. Gonna merge this now!

deadlycoconuts self-assigned this Mar 12, 2024

deadlycoconuts force-pushed the update_turing_api_server_dependencies branch 3 times, most recently from 3e72566 to e871a99 Compare March 19, 2024 06:01

deadlycoconuts added 26 commits April 5, 2024 12:13

Remove unused authz middleware

9527be9

Remove authz related configs

64fb3c5

Bump up version dependencies

1cc413a

Update go version in github workflow

bbc7979

Add step to install go 1.22

f605ce2

Update knative pkg

e68a2d6

Update containerregistry package

bab4a81

Update go mod file to use branched merlin package version

402ac97

Update turing api dockerfile to use newer version of go

016c9af

Update golanci-lint version

4e4eab3

Move jsonError helper function from removed authz file to openapi val…

ebb6340

…idation file

Specify go-hclog version

3a2686d

Rename unused function arguments in experiment engines

243d2a3

Fix lint comments in turing router

79cd55b

Rollback zap version

474d8f0

Update zap-to-hclog in experiment, router, and api

7a5555b

Refactor merlin's environments api

39426b7

Update go version for router and experiment engine

85cdeef

Add steps to install go 1.22 for experiment engine and router

1a8edd3

Update zap and mlp in experiment engines and router

db258a7

Patch new EnvironmentsGet method

1dc0106

Remove steps to verify the same google auth client is created by merl…

19a53e3

…in and mlp

Add custom compare function to allow nested unexported fields

a1f07ed

Refactor e2e tests to make them compatible with previously used libra…

5ba91e7

…ries

Clean up refactoring of mlp service

9b41165

Bump up ginkgo versions

f5bc53f