Improve unit tests for Config and Transformer

carandclassic · Jan 20, 2019 · 0143a5a · 0143a5a
1 parent 4c4fb54
commit 0143a5a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tests/PrivateDump/ConfigTest.php b/tests/PrivateDump/ConfigTest.php
@@ -15,7 +15,9 @@ public function weCanOverrideConnectionConfig()
             'password' => 'expelliarmus'
         ]]);
 
+        $this->assertEquals('root', $this->config->get('connection.username'));
         $this->assertEquals('expelliarmus', $this->config->get('connection.password'));
+        $this->assertEquals('localhost', $this->config->get('connection.hostname'));
     }
 
     /** @test */

diff --git a/tests/PrivateDump/TransformerTest.php b/tests/PrivateDump/TransformerTest.php
@@ -21,7 +21,7 @@ public function nonFakerTransformersWork()
         $this->assertRegExp('/[0-9]{13}/', $this->transformer->transform('test', 'barcodeEan13'));
         $this->assertRegExp('/[0-9]{8}/', $this->transformer->transform('test', 'barcodeEan8'));
         $this->assertRegExp('/[0-9]{13}/', $this->transformer->transform('test', 'isbn13'));
-        $this->assertRegExp('/[0-9]{10}/', $this->transformer->transform('test', 'isbn10'));
+        $this->assertRegExp('/[0-9A-Z]{10}/', $this->transformer->transform('test', 'isbn10'));
 
         $this->assertEquals('TEST', $this->transformer->transform('tEsT', 'uppercase'));
         $this->assertEquals('test', $this->transformer->transform('tEsT', 'lowercase'));