Skip to content

Commit

Permalink
include addressType for valid PSBT translation in SignMultisigTransac…
Browse files Browse the repository at this point in the history
…tion
  • Loading branch information
chadchapnick committed Dec 12, 2024
1 parent 48da7df commit a45e430
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/nine-berries-float.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@caravan/wallets": patch
---

include addressType for valid PSBT translation in SignMultisigTransaction
1 change: 1 addition & 0 deletions packages/caravan-wallets/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ export function SignMultisigTransaction({
bip32Paths,
psbt,
keyDetails,
addressType: walletConfig.addressType,
returnSignatureArray,
});
default:
Expand Down
2 changes: 1 addition & 1 deletion packages/caravan-wallets/src/ledger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -990,7 +990,7 @@ export class LedgerSignMultisigTransaction extends LedgerBitcoinInteraction {

const translatedPsbt = translatePSBT(
network,
P2SH,
v2Options?.addressType || P2SH,
this.psbt,
keyDetails
);
Expand Down
3 changes: 2 additions & 1 deletion packages/caravan-wallets/src/trezor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -701,6 +701,7 @@ export class TrezorSignMultisigTransaction extends TrezorInteraction {
psbt,
keyDetails,
returnSignatureArray,
addressType,
}) {
super({ network });
if (!psbt || !keyDetails) {
Expand All @@ -715,7 +716,7 @@ export class TrezorSignMultisigTransaction extends TrezorInteraction {
}
const translatedPsbt = translatePSBT(
network,
P2SH,
addressType,
this.psbt,
keyDetails
);
Expand Down

0 comments on commit a45e430

Please sign in to comment.