fix: multisig support for indirect keystore interactions #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e6800c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Changes look good. needs a changeset to indicate a patch update (I think that's sufficient for this fix) |
|
Nice catch! I verified that this fixes signing on coldcard devices |
bucko13
reviewed
Aug 29, 2024
.changeset/twenty-spies-kneel.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@caravan/psbt": major | |||
There was a problem hiding this comment.
I think we can make this a patch. It's not backwards incompatible in any way and isn't a new feature. Just an (important) bug fix.
chadchapnick
force-pushed
the
fix/multisig-psbt-support
branch
from
399d351 to
dd6ce2b
Compare
chadchapnick
force-pushed
the
fix/multisig-psbt-support
branch
from
dd6ce2b to
5e6800c
Compare
bucko13
approved these changes
Aug 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in which PSBTs could not be signed in indirect keystore interactions due to a missing redeem script.
Introduced in #91