Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unknown network error for regtest #156

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

chadchapnick
Copy link
Contributor

Checks for REGTEST network in Coldcard and Custom interactions rather than throwing "Unknown network"

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
caravan-coordinator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 9:58pm

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: f0021fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@caravan/wallets Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@bucko13 bucko13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an array somewhere in @caravan/bitcoin that has these (including signet) that we could just check for. but this is fine for now. Thanks!

@chadchapnick
Copy link
Contributor Author

I'm seeing at least one other location this same subset is hardcoded in @carvan/bitcoin. The reusable array would be much easier to maintain!

@bucko13 bucko13 merged commit a35893d into caravan-bitcoin:main Nov 18, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants