feat(layer): first pass at Layer component

[SimpleProgrammingAU]

I've had a crack at implementing the Layer component.

I wasn't sure how to approach porting the useLayer function from React.

Also, how should we set the Context value?

[brunnerh]

• This does not account for dynamically changing levels, which would require the use of a store in the context and a reactive statement to update the local level/store on change. Not sure if this is worth supporting, though.
• Personally, I would prefix context keys consistently to preempt collisions, e.g. use something like 'carbon.layer'/'carbon-components.layer' in this case. If something like this is done, it should apply everywhere, though. So maybe a separate PR would make more sense.

[SimpleProgrammingAU]

Can we make the context reactive? Could something like this work?

  $: parentLevel = getContext("LAYER_CONTEXT");
  $: {if (level === undefined) {
      level = typeof parentLevel === "number" ? parentLevel + 1 : 0;
    }
    setContext("LAYER_CONTEXT", level);
  }

Will take advice on the approach to the context name.

[brunnerh]

This will not work, contexts are fixed, they are set during child component construction.
That is why you would need a store.

[SimpleProgrammingAU]

Alright. I'll wait to see what others say about whether or not to use stores and how to approach naming.

[brunnerh]

Was confused by all the changes here, looks like code sections are not generated correctly. Pretty sure stuff like this breaks the table.

[brunnerh]

Could be a platform issue, \r\n vs just \n (i.e. Windows vs other systems).
In the JSON file there are now a bunch of \r, so the \n of an \r\n was probably stripped.

If this is correct, the issue might be in sveld.

[SimpleProgrammingAU]

Lemme know if there is anything I can do on my end to help resolve. I'm on a Win11 system using VSC.

As mentioned in a previous thread, I get heaps of changes in git when I do a rebuild of the docs. Could it be something to do with my configuration?

[brunnerh]

If you have the Git setting core.autocrlf on true, changing it to false could help (a new checkout may also be necessary to update the files). This flag causes files to be checked out with \r\n rather than just \n, in most cases it should not be necessary, though.

Of course ideally the docs would be generated correctly either way.

[SimpleProgrammingAU]

I think this might have resolved it. All the files are still marked "modified" for some reason, but there's no visible changes in the files. I have whitespace diff visible, too.

Not sure what's going on now. Hopefully, the issue just goes away with the next branch I create.

[metonym]

Excellent, thank you!