Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextHighlighter): Add TextHighlighter component - React #384

Merged
merged 9 commits into from
Jan 30, 2025

Conversation

punnoosewilson
Copy link
Member

Closes #

Here we have a component offering 3 variants:

  • 1st variant - <mark> : This HTML element represents text which is marked or highlighted for reference or notation purposes.
  • 2nd variant - <ins> : This HTML element represents a range of text that has been added to a document. (Comparison purpose)
  • 3rd variant - <del> : This HTML element represents a range of text that has been deleted from a document. (Comparison purpose)

image

Changelog

New

  • {{new thing}}

Changed

  • {{change thing}}

Removed

  • {{removed thing}}

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for carbon-labs-react ready!

Name Link
🔨 Latest commit a9f6c49
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs-react/deploys/679b07ca5b83d90008e51058
😎 Deploy Preview https://deploy-preview-384--carbon-labs-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for carbon-labs-web-components ready!

Name Link
🔨 Latest commit a9f6c49
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs-web-components/deploys/679b07ca0c29f50008531daa
😎 Deploy Preview https://deploy-preview-384--carbon-labs-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1
Copy link
Member

annawen1 commented Jan 28, 2025

Awesome work @punnoosewilson! Can you tag the relevant folks to the PR to review?

Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew merged commit 61dca6b into carbon-design-system:main Jan 30, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants