Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluid heading styles docs #4043

Merged
merged 5 commits into from
May 12, 2024

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Apr 29, 2024

It helps with #3747

Update fluid heading styles docs

Changelog

Changed

  • Update fluid heading styles docs

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 6:43pm

@jeanservaas
Copy link
Collaborator

At @abdonrd I think we can get even more clear on the behavior description. I took a pass here.

Current copy

Fluid heading styles
The fluid heading styles are primarily used in web pages, and are therefore part of the expressive set of type styles. These headings are responsive and the type styles change size at different breakpoints.

Do not use these styles inside a container. They may be used in product pages where text sits outside of a container, and a blend of expressive and productive type styles is desired for hierarchy and distinction. For more information, see Style strategies.

Updated copy

Fluid heading styles
The fluid heading styles are primarily used in web pages, and are therefore part of the expressive set of type styles. These headings are responsive and the type styles actually change size incrementally (almost imperceptibly) between the different breakpoints — hence the name "fluid."

Do not use these styles inside a container. They may be used in product pages where text sits outside of a container, and a blend of expressive and productive type styles is desired for hierarchy and distinction. For more information, see Style strategies.

Note: the slider below shows the type sizes jumping abruptly between breakpoints, which is not a good representation of the actual behavior.

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeanservaas for the clarification!
Good catch @abdonrd, looks good to me 🎉

@abdonrd abdonrd requested a review from a team as a code owner May 12, 2024 18:39
@abdonrd abdonrd requested a review from guidari May 12, 2024 18:39
@Kritvi-bhatia17 Kritvi-bhatia17 enabled auto-merge (squash) May 12, 2024 18:39
@Kritvi-bhatia17 Kritvi-bhatia17 merged commit 0f40a8c into carbon-design-system:main May 12, 2024
7 checks passed
@abdonrd abdonrd deleted the patch-1 branch May 12, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants