add vertical tab usage and style documentation #4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thyhmdo
reviewed
Jun 20, 2024
thyhmdo
reviewed
Jun 20, 2024
thyhmdo
reviewed
Jun 20, 2024
thyhmdo
reviewed
Jun 20, 2024
thyhmdo
reviewed
Jun 20, 2024
| | | | border-right | `$border-subtle` \* | | ||
| | Selected | Tab | background-color | `$layer` \* | | ||
| | | | border-bottom | `$border-subtle` \* | | ||
| | | | border-left | `$border-interactive` \* | |
There was a problem hiding this comment.
double checking but I don't think border-subtle is contextual so it doesn't have \ *
There was a problem hiding this comment.
@thyhmdo i think border styles do have layer tokens looking at components like dropdown or progress indicator
thyhmdo
reviewed
Jun 20, 2024
thyhmdo
reviewed
Jun 20, 2024
thyhmdo
reviewed
Jun 20, 2024
|
This looks great, and it has come a long way for tabs! |
Co-authored-by: thyhmdo <[email protected]>
Co-authored-by: thyhmdo <[email protected]>
Co-authored-by: thyhmdo <[email protected]>
Co-authored-by: thyhmdo <[email protected]>
Co-authored-by: thyhmdo <[email protected]>
|
Looks great! There's only one thing unrelated to this update, this could be a typo in the Overview image. We can open another small issue. "The summary inaccurately sates that..."
|
thyhmdo
approved these changes
Jun 27, 2024
alisonjoseph
approved these changes
Jun 28, 2024
guidari
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding vertical tab usage and style documentation to website
related PR: carbon-design-system/carbon#16738
Closes: #4077
New