Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy edits for data-table usage content #4312

Merged
merged 10 commits into from
Nov 6, 2024
Merged

Copy edits for data-table usage content #4312

merged 10 commits into from
Nov 6, 2024

Conversation

crlordan
Copy link
Contributor

@crlordan crlordan commented Oct 4, 2024

Working on changes in this issue: #4235

Working to improve the content of the data-table component.

Changelog

Changed

  • Copy edits for the Universal Behaviors section.
  • Added a subhead to the entry in the Modifiers section, to match other components and label the modified more clearly.

@crlordan crlordan requested review from a team as code owners October 4, 2024 19:16
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 5:47pm

@alisonjoseph
Copy link
Member

Hi, thanks for the contribution, you'll want to run yarn format locally for ci to pass

@crlordan
Copy link
Contributor Author

I ran yarn format and now the ci checks have passed.

@crlordan
Copy link
Contributor Author

@alisonjoseph Hi, wondering if this PR could be reviewed and merged now that the checks have passed? Thank you.

@crlordan crlordan mentioned this pull request Oct 15, 2024
Closed
@aagonzales aagonzales self-requested a review October 30, 2024 16:21
aagonzales
aagonzales approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! I had one suggestion of adding a crosslink to the Accessibility tab.

src/pages/components/data-table/usage.mdx Outdated Show resolved Hide resolved
@aagonzales aagonzales removed the request for review from oliviaflory October 30, 2024 16:31
@aagonzales aagonzales linked an issue Oct 30, 2024 that may be closed by this pull request
[UI Content Design Guild] Data table component topic is missing content #4235
Closed
@alisonjoseph alisonjoseph enabled auto-merge (squash) November 4, 2024 14:04
emyarod
emyarod reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the format check is still failing?

@alisonjoseph alisonjoseph merged commit 6abdb2e into carbon-design-system:main Nov 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@aagonzales aagonzales aagonzales approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI Content Design Guild] Data table component topic is missing content
4 participants
@crlordan @alisonjoseph @emyarod @aagonzales