Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated images in the Dropdown's Style and Accessibility tabs to display the focus state #4342

Merged
merged 17 commits into from
Nov 18, 2024
Merged

fix: Updated images in the Dropdown's Style and Accessibility tabs to display the focus state #4342

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
00404af
Updated Style & Accessibility tab images
Kritvi-bhatia17 Oct 29, 2024
10de726
Updated focus state
Kritvi-bhatia17 Oct 29, 2024
c9b0aa7
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Oct 29, 2024
4526036
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Oct 30, 2024
333fe41
Post-review updates
Kritvi-bhatia17 Oct 31, 2024
5d48cb8
Post-review updates
Kritvi-bhatia17 Oct 31, 2024
9dc3eb8
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Oct 31, 2024
07f38b4
yarn:format
alisonjoseph Oct 31, 2024
37c4f2b
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Nov 5, 2024
4f77a78
Merge branch 'main' into Dropdown_images
laurenmrice Nov 5, 2024
7151b59
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Nov 6, 2024
85a450b
Post-review updates
Kritvi-bhatia17 Nov 6, 2024
fd36c85
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Nov 7, 2024
0bcec9d
Image minor fixes
Kritvi-bhatia17 Nov 8, 2024
444e401
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Nov 8, 2024
9cbc09e
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Nov 13, 2024
0cb7c8f
Merge branch 'main' into Dropdown_images
Kritvi-bhatia17 Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/pages/components/dropdown/images/combobox-style-default-states.png
View file
Open in desktop
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/dropdown/images/combobox-style-fluid-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/dropdown/images/dropdown-accessibility-2.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/dropdown/images/dropdown-accessibility-3.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/dropdown/images/dropdown-accessibility-4.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/pages/components/dropdown/images/dropdown-combobox-style-default-states.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/pages/components/dropdown/images/dropdown-combobox-style-fluid-states.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/pages/components/dropdown/images/dropdown-multiselect-style-default-states.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/pages/components/dropdown/images/dropdown-multiselect-style-fluid-states.png
View file
Open in desktop
Binary file not shown.
Binary file modified src/pages/components/dropdown/images/dropdown-style-4.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/dropdown/images/dropdown-style-default-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/dropdown/images/dropdown-style-fluid-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/dropdown/images/multiselect-style-default-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/dropdown/images/multiselect-style-fluid-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
34 changes: 29 additions & 5 deletions src/pages/components/dropdown/style.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ structure, and size and AI presence.

<Tab label="Default">

![Default dropdown and combo box states](images/dropdown-combobox-style-default-states.png)
![Default dropdown states](images/dropdown-style-default-states.png)

</Tab>

<Tab label="Fluid">

![Fluid dropdown and combo box states](images/dropdown-combobox-style-fluid-states.png)
![Fluid dropdown states](images/dropdown-style-fluid-states.png)

</Tab>

Expand All @@ -140,7 +140,7 @@ structure, and size and AI presence.
</Column>
</Row>

<Caption>Dropdown and combo box states</Caption>
<Caption>Dropdown states</Caption>
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved

<Row>
<Column colLg={12}>
Expand All @@ -149,13 +149,37 @@ structure, and size and AI presence.

<Tab label="Default">

![Default multiselect dropdown states](images/dropdown-multiselect-style-default-states.png)
![Default combo box dropdown states](images/combobox-style-default-states.png)
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved

</Tab>

<Tab label="Fluid">

![Fluid multiselect dropdown states](images/dropdown-multiselect-style-fluid-states.png)
![Fluid combo box dropdown states](images/combobox-style-fluid-states.png)
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved

</Tab>

</Tabs>

</Column>
</Row>

<Caption>Combo box dropdown states</Caption>
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved

<Row>
<Column colLg={12}>

<Tabs>

<Tab label="Default">

![Default multiselect dropdown states](images/multiselect-style-default-states.png)
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved

</Tab>

<Tab label="Fluid">

![Fluid multiselect dropdown states](images/multiselect-style-fluid-states.png)
Kritvi-bhatia17 marked this conversation as resolved.
Show resolved Hide resolved

</Tab>

Expand Down
Loading