fix(search): use undefined

carbon-design-system · Jun 26, 2024 · 58b3290 · 58b3290
1 parent 1509652
commit 58b3290
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap b/packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap
@@ -502,9 +502,7 @@ exports[`DataTable behaves as expected selection should render and match snapsho
         >
           <div
             aria-expanded="false"
-            aria-label=""
             class="cds--search-magnifier"
-            role=""
             tabindex="-1"
           >
             <svg
@@ -936,9 +934,7 @@ exports[`DataTable renders as expected - Component API should render and match s
         >
           <div
             aria-expanded="false"
-            aria-label=""
             class="cds--search-magnifier"
-            role=""
             tabindex="-1"
           >
             <svg

diff --git a/...es/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap b/...es/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap
@@ -9,9 +9,7 @@ exports[`TableToolbarSearch renders as expected - Component API should render 1`
   >
     <div
       aria-expanded="false"
-      aria-label=""
       class="cds--search-magnifier"
-      role=""
       tabindex="-1"
     >
       <svg

diff --git a/packages/react/src/components/Search/Search.tsx b/packages/react/src/components/Search/Search.tsx
@@ -228,9 +228,9 @@ const Search = React.forwardRef<HTMLInputElement, SearchProps>(function Search(
       however, it does not need a keyboard event bc the input element gets focus on keyboard nav and expands that way*/}
       {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events */}
       <div
-        aria-label={onExpand ? 'button' : ''}
+        aria-label={onExpand ? 'button' : undefined}
         aria-labelledby={onExpand ? uniqueId : undefined}
-        role={onExpand ? 'button' : ''}
+        role={onExpand ? 'button' : undefined}
         className={`${prefix}--search-magnifier`}
         onClick={onExpand}
         onKeyDown={handleExpandButtonKeyDown}