Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Vertical alignment of icons in buttons with both icon and text #15553

Closed
2 tasks done
marcin-bartos-viacomcbs opened this issue Jan 17, 2024 · 2 comments · Fixed by #15585
Closed
2 tasks done
Assignees
Milestone

Comments

@marcin-bartos-viacomcbs

Package

@carbon/react, @carbon/styles

Browser

Chrome, Firefox

Package version

v1.47.0

React version

v18.2.0

Description

When we use a Button component with both text and an icon, the vertical alignment of the icon seems to change depending on Button size variation.

For sizes "sm" and "md" the icon is vertically aligned to the bottom of the text. For sizes "lg" up, the icon is vertically centered with the text. I've prepared a screenshot where I've added a background and zoomed in to showcase the difference:
image

I don't know if this is a bug or a design choice. The only guideline I've found on a website is related to icon alignment with text
https://carbondesignsystem.com/guidelines/icons/usage#alignment
For me, it makes sense to apply the same rule to buttons. The icon aligned to the bottom of the text visually seems slightly off. However, if this is intentional please let me know :)

Reproduction/example

https://stackblitz.com/edit/github-3qj9uz?file=src%2FApp.jsx

Steps to reproduce

  1. zoom in on the preview pane
  2. check how the icon is vertically aligned with dotted lines

Suggested Severity

None

Application/PAL

No response

Code of Conduct

@tw15egan
Copy link
Collaborator

Question for @carbon-design-system/design, let us know what needs to be modified 👍🏻

@laurenmrice
Copy link
Member

The icon should always be vertically aligned with the text in the button. So the sm and md size buttons have bugs.

@tw15egan tw15egan self-assigned this Jan 18, 2024
@tw15egan tw15egan moved this to 🏗 In Progress in Design System Jan 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Jan 26, 2024
@alisonjoseph alisonjoseph added this to the 2024 Q1 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants