fix(Button): adjust button icon in small, medium size #15585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andreancardona
added
status: one more review 👀
and removed
status: ready for review 👀
labels
guidari
approved these changes
Jan 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jan 26, 2024
c8b452a
21 of 22 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15553
Removes some margin that was causing alignment issues in the
smandmdvariants ofButtonwith arenderIconprop set.Changelog
Changed
smandmdnon-icon-only variants ofButtonTesting / Reviewing
I replicated the test story from the bug report for easier verification that the issue was resolved (
Button --> ButtonTest). I will remove it before merging.