Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ContainedList.ContainedListItem usage #16354

Closed
2 of 3 tasks
tay1orjones opened this issue May 8, 2024 · 3 comments
Closed
2 of 3 tasks

Deprecate ContainedList.ContainedListItem usage #16354

tay1orjones opened this issue May 8, 2024 · 3 comments
Assignees
@Gururajj77
Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.

Comments

@tay1orjones
Copy link
Member

tay1orjones commented May 8, 2024 •
edited by Gururajj77
Loading

Surfaced in #16302 (comment), ContainedListItem is a field on ContainedList. The convention so far in v11 is to avoid adding subcomponents as fields on parent/sibling component objects/exports.

Tasks
Preview Give feedback
@tay1orjones tay1orjones added role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc. labels May 8, 2024
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System May 8, 2024
@tay1orjones tay1orjones mentioned this issue May 8, 2024
Merged
@Gururajj77 Gururajj77 self-assigned this May 9, 2024
@tay1orjones tay1orjones added this to the 2024 Q2 milestone May 22, 2024
@Gururajj77 Gururajj77 moved this from ⏱ Backlog to 🏗 In Progress in Design System May 23, 2024
@Gururajj77 Gururajj77 mentioned this issue May 23, 2024
Merged
@Gururajj77 Gururajj77 moved this from 🏗 In Progress to ✅ Done in Design System May 24, 2024
@Gururajj77 Gururajj77 closed this as completed by moving to ✅ Done in Design System May 24, 2024
@Gururajj77 Gururajj77 moved this from ✅ Done to 🏗 In Progress in Design System May 24, 2024
@Gururajj77
Copy link
Contributor

Completed via #16552

@Gururajj77 Gururajj77 reopened this May 24, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ⏱ Backlog in Design System May 24, 2024
@Gururajj77 Gururajj77 moved this from ⏱ Backlog to 🏗 In Progress in Design System May 24, 2024
@Gururajj77 Gururajj77 mentioned this issue Jun 3, 2024
Merged
@Gururajj77
Copy link
Contributor

@tay1orjones , where should I document about the last part? not able to find developer style guild.

@Gururajj77
Copy link
Contributor

closed via #16640

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in Design System Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gururajj77 Gururajj77

Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Design System
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tay1orjones @Gururajj77