Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recorded Containedlistitem usage depreciation #16640

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

Gururajj77
Copy link
Contributor

Closes third task of #16354

Recorded the depreciation of the usage, ContainedList.ContainedListItem in the mdx docs.

Changelog

New

  • added the depreciation message and how to use the new import.

Testing / Reviewing

check the github docs for ContainedList.mdx to see the latest doc update

@Gururajj77 Gururajj77 requested a review from a team as a code owner June 3, 2024 08:58
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit feaf599
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/665d8cef68cf450008cac89d
😎 Deploy Preview https://deploy-preview-16640--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit feaf599
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/665d8cef83ecf10008058e18
😎 Deploy Preview https://deploy-preview-16640--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -100,6 +100,10 @@ render inline to the Contained List title, please see the
also remain persistent under the title, so that it remains visible on scroll,
when there are many list items passed in.

`ContainedList.ContainedListItem` is deprecated, use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please move this message below? this is coming in between the persistent search elaboration

Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gururajj77 Gururajj77 added this pull request to the merge queue Jun 11, 2024
Merged via the queue into carbon-design-system:main with commit 534710f Jun 11, 2024
21 checks passed
@Gururajj77 Gururajj77 deleted the containedlist-docs branch June 11, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants