fix: switch to onClick from onMouseDown in modal components #16847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmenendez
changed the title
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
riddhybansal
approved these changes
Jun 25, 2024
Gururajj77
approved these changes
Jun 25, 2024
tay1orjones
requested changes
Jun 25, 2024
|
@tay1orjones resolved 👍 |
|
@davidmenendez would you be up for writing a small test to ensure the consumer-provided onClick is called like we expect? |
|
@tay1orjones tests included 👍 |
|
@tay1orjones when you have a chance 👍 |
alisonjoseph
approved these changes
Jul 1, 2024
Closed
2 tasks
|
@tay1orjones 👀 😬 |
tay1orjones
approved these changes
Jul 16, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jul 16, 2024
b12ac2e
22 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16846
switches the outside click detector event in
ModalandComposedModalfromonMouseDowntoonClickin order to alleviate some strange behaviors noticed with components built onListBoxinside of modal components.Changelog
Changed
onMouseDownevent toonClickinModalandComposedModalTesting / Reviewing