Add Typescript annotations to NumberInputSkeleton #12877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert existing propType definitions to Typescript annotations on the NumberInputSkeleton component. This is part of a broader effort to add Typescript annotations to components, tracked in carbon-design-system#12513. Closes carbon-design-system#12549. Type annotation changes only; no breaking feature changes.
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Dec 21, 2022
aledavila
approved these changes
Jan 18, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12549
Convert existing propType definitions to Typescript annotations on the NumberInputSkeleton component. This is part of a broader effort to add Typescript annotations to components, tracked in #12513.
Changelog
Changed
Testing / Reviewing
yarn build,yarn storybook. In the storybook, navigate to NumberInputSkeleton and confirm that the component's behavior remains unchanged.// @ts-checkas the first line in the file (temporarily, just for the sake of this test). Scroll down to NumberInputSkeleton and confirm that no error is displayed. Add hideLabel={6} and confirm that an error is displayed. Change to hideLabel={true} and confirm that the error goes away. Restore NumberInput.stories.js to its prior state.