Time picker - New states and icons #13851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
francinelucca
requested changes
May 22, 2023
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
tay1orjones
approved these changes
May 24, 2023
There was a problem hiding this comment.
Forgot to leave one comment, but it's non-blocking.
@thyhmdo this one's ready for a visual review
Comment on lines
+47
to
+48
| // top/transform used to center invalid icon in IE11 | ||
| transform: translateY(-50%); |
There was a problem hiding this comment.
IE11 isn't in our support matrix as of v11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13647
Description
invalidstate and to the newwarningstate.New
Added a new state called warning.
Testing
invalidandwarningstate to check if they are working as expected.