Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVT] - Added Keyboard Nav AVT test for ComboButton #14687

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Sep 20, 2023

Closes #14680

Added keyboard navigation to ComboButton component.

Changelog

New

  • Added new file e2e/components/ComboButton/ComboButton-test.avt.e2e.js

Testing / Reviewing

  • Ensure the test pass.
  • Ensure that the expected navigation is covered.

@guidari guidari requested a review from a team as a code owner September 20, 2023 11:32
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 159336b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/650ad858a9fb330008fb4a29
😎 Deploy Preview https://deploy-preview-14687--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 159336b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/650ad858aae94500088ddeee
😎 Deploy Preview https://deploy-preview-14687--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@guidari guidari added this pull request to the merge queue Sep 27, 2023
Merged via the queue into carbon-design-system:main with commit 384fa42 Sep 27, 2023
@guidari guidari deleted the 14680-combo-button branch September 27, 2023 22:52
@carbon-automation
Copy link
Contributor

Hey there! v11.39.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard Nav AVT test for ComboButton
3 participants