-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added aria-live to stop extraneous announcement #14778
Merged
tay1orjones
merged 5 commits into
carbon-design-system:main
from
guidari:14269-datatable
Oct 9, 2023
Merged
fix: added aria-live to stop extraneous announcement #14778
tay1orjones
merged 5 commits into
carbon-design-system:main
from
guidari:14269-datatable
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
approved these changes
Oct 4, 2023
tay1orjones
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent we're able to close so many with this small change!
Merged
via the queue into
carbon-design-system:main
with commit Oct 9, 2023
553763a
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14271
Closes #14269
Closes #14260
Closes #14257
Closes #14255
Shoutout to @tw15egan for helping out!! 🚀
Added
aria-live
attribute to avoid extraneous announcement when using the VO or JAWSTesting / Reviewing
Use VO or JAWS in the following storybook variants: