Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added aria-live to stop extraneous announcement #14778

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Oct 4, 2023

Closes #14271
Closes #14269
Closes #14260
Closes #14257
Closes #14255

Shoutout to @tw15egan for helping out!! 🚀

Added aria-live attribute to avoid extraneous announcement when using the VO or JAWS

Testing / Reviewing

Use VO or JAWS in the following storybook variants:

  • components-datatable-selection--with-radio-selection
  • components-datatable-batch-actions--default

@guidari guidari requested a review from a team as a code owner October 4, 2023 15:30
@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0da3427
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/651da603736e1700083bc08e
😎 Deploy Preview https://deploy-preview-14778--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0da3427
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/651da603a545ce0007bdea03
😎 Deploy Preview https://deploy-preview-14778--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent we're able to close so many with this small change!

@tay1orjones tay1orjones added this pull request to the merge queue Oct 9, 2023
Merged via the queue into carbon-design-system:main with commit 553763a Oct 9, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment