fix(bug): slider.scss uses deprecated /
#15063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
requested changes
Oct 30, 2023
tw15egan
approved these changes
Oct 30, 2023
alewitt2
commented
Oct 30, 2023
tay1orjones
approved these changes
Oct 30, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
an accidental deprecated division `/` snuck in and is causing sass loader errors downstream.
Co-authored-by: Taylor Jones <[email protected]>
tay1orjones
removed this pull request from the merge queue due to the queue being cleared
tay1orjones
added a commit
to tay1orjones/carbon
that referenced
this pull request
Nov 1, 2023
* fix(bug): slider.scss uses deprecated `/` an accidental deprecated division `/` snuck in and is causing sass loader errors downstream. * Update packages/styles/scss/components/slider/_slider.scss Co-authored-by: Taylor Jones <[email protected]> * Update packages/styles/scss/components/slider/_slider.scss --------- Co-authored-by: Taylor Jones <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an accidental deprecated division
/snuck in and is causing sass loader errors downstream.Closes # #15062
cant load
@use carbon/reactin scssChangelog
Changed
/Testing / Reviewing
make sure slider still works as expected, and no sass warnings