feat(ListBox): add slug prop to Dropdown, MultiSelect, ComboBox, and Select
#15206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
changed the title
slug prop to Dropdown, MultiSelect, and ComboBoxslug prop to Dropdown, MultiSelect, ComboBox, and Select
|
Percy error is due to the change in |
tay1orjones
reviewed
Nov 16, 2023
tay1orjones
approved these changes
Nov 16, 2023
|
@tay1orjones I think this is just a side effect of the Update: actually, I think this is exacerbated because we now have a rounded border on the callout. We may have to bump the position of the caret a few pixels for the slug callout |
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
Nov 16, 2023
…x`, and `Select` (carbon-design-system#15206) * feat(TextInput): support slug prop * fix(TextInput): add types for slug prop * refactor(Slug): remove old file, move demo to form story * docs(Storybook): update form story * feat(NumberInput): add slug to NumberInput * refactor(NumberInput): remove pseudo elements and use box-shadow * style(NumberInput): fix issue with z-index, add invalid styles * feat(DatePicker): add slug prop to DatePickerInput * feat(TextArea): add slug prop to TextArea * test(snapshot): update snapshots * fix(TextArea): remove console warning * style(Fluid): adjust styles for fluid inputs * docs(Storybook): fix ids * fix(Slug): adjust positioning, add storybook controls * fix(Storybook): add story styles to form example * fix(Slug): adjust positioning when invalid, warning state * style(Slug): adjust padding when slug is present * docs(Storybook): add examples with revert functionality * fix(NumberInput): fix type error * refactor(storybook): adjust stories * feat(Slug): add revertLabel prop * fix(Undo): replace undo, redo with coreect asset * feat(ListBox): add Slug prop to ListBox components * fix(Slug): adjust revert positioning, remove margin * docs(Storybook): rearrange storybook order * fix(NumberInput): don't set defaultValue if not provided, remove console * feat(Select): add Slug prop to Select * chore(files): add ai-gradient to react package * test(snapshot): update snapshots * refactor(Slug): remove aria-hidden
Closed
|
@tw15egan @aagonzales I found a couple overlap and alignment issues. Are these tracked in issues yet? 
|
|
No issues for things like that yet, can you start one that has any issues you see with the 9 components merged in, and then which variant/state it's occurring? I just need to adjust some padding/positioning between fluid/default states, but I want to ensure I get them all. |
|
@tw15egan will do. I'll create the issue. |
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
…x`, and `Select` (carbon-design-system#15206) * feat(TextInput): support slug prop * fix(TextInput): add types for slug prop * refactor(Slug): remove old file, move demo to form story * docs(Storybook): update form story * feat(NumberInput): add slug to NumberInput * refactor(NumberInput): remove pseudo elements and use box-shadow * style(NumberInput): fix issue with z-index, add invalid styles * feat(DatePicker): add slug prop to DatePickerInput * feat(TextArea): add slug prop to TextArea * test(snapshot): update snapshots * fix(TextArea): remove console warning * style(Fluid): adjust styles for fluid inputs * docs(Storybook): fix ids * fix(Slug): adjust positioning, add storybook controls * fix(Storybook): add story styles to form example * fix(Slug): adjust positioning when invalid, warning state * style(Slug): adjust padding when slug is present * docs(Storybook): add examples with revert functionality * fix(NumberInput): fix type error * refactor(storybook): adjust stories * feat(Slug): add revertLabel prop * fix(Undo): replace undo, redo with coreect asset * feat(ListBox): add Slug prop to ListBox components * fix(Slug): adjust revert positioning, remove margin * docs(Storybook): rearrange storybook order * fix(NumberInput): don't set defaultValue if not provided, remove console * feat(Select): add Slug prop to Select * chore(files): add ai-gradient to react package * test(snapshot): update snapshots * refactor(Slug): remove aria-hidden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15188
Closes #15186
This PR adds the
slugprop to allListBoxcomponents (Dropdown,MultiSelect,FilterableMultiSelect,and
ComboBox) as well asSelect.Changelog
New
slugLabeladded toSlugthat is passed down toToggletipButtonto change the text that is narrated when focusing on theSlugwith a screenreaderToggletiporIconButtonvia...restListboxcomponents tolist-box.scss,SelectstylesChanged
AI Formstory (Form-->AI Formin Storybook)Warningicon inner path showing up with the incorrect color in dark themes (should always beblack-100)Testing / Reviewing
Go to
Form --> Ai Formin Storybook and ensure the components listed above match the spec