Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs - Fixed arrow navigation #15632

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Jan 29, 2024

Closes #14819

Now we are filtering null values in the array. The arrow navigation was not working due to the null values.

Testing / Reviewing

  • Go to dismissable tabs variant;
  • Delete a Tab;
  • Use the arrow navigation.

@guidari guidari requested a review from a team as a code owner January 29, 2024 20:23
Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a26761
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65b8093418830d00082c8cd8
😎 Deploy Preview https://deploy-preview-15632--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Feb 13, 2024
Merged via the queue into carbon-design-system:main with commit 04e231f Feb 13, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug & a11y]: Tabs [dismissible] - keyboard interaction not possible after dismissing tab
3 participants