fix(fileuploaderitem): allow configurable className #15879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surfaced in slack. For some reason
className
wasn't being applied in thecx()
call, instead relying on the prop spread on thespan
. So if you passed in aclassName
, all the built in classes wouldn't be applied.Here's a repro of the bug: https://stackblitz.com/edit/github-svhol5?file=src%2FApp.jsx
Is this intentional? I can't find a related PR or anything, but maybe I missed something 🤔
Changelog
Changed
className
in addition to the internal classnamesTesting / Reviewing