Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fileuploaderitem): allow configurable className #15879

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

tay1orjones
Copy link
Member

Surfaced in slack. For some reason className wasn't being applied in the cx() call, instead relying on the prop spread on the span. So if you passed in a className, all the built in classes wouldn't be applied.

Here's a repro of the bug: https://stackblitz.com/edit/github-svhol5?file=src%2FApp.jsx

Is this intentional? I can't find a related PR or anything, but maybe I missed something 🤔

Changelog

Changed

  • use className in addition to the internal classnames

Testing / Reviewing

  • If you pass in a className, the default styles should still be applied.

@tay1orjones tay1orjones requested a review from a team as a code owner March 4, 2024 13:52
@tay1orjones tay1orjones self-assigned this Mar 4, 2024
@tay1orjones tay1orjones added role: dev 🤖 component: file-uploader type: bug 🐛 severity: 2 https://ibm.biz/carbon-severity severity: 3 https://ibm.biz/carbon-severity and removed severity: 2 https://ibm.biz/carbon-severity labels Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 1101a92
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e61e2ae4d6960008054b61
😎 Deploy Preview https://deploy-preview-15879--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird, definitely seems like a bug and not intentional. 👍

@guidari guidari added this pull request to the merge queue Mar 4, 2024
Merged via the queue into carbon-design-system:main with commit 59dbf52 Mar 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants