Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: side panel as modal kind (proposal / talking point) #15882

Closed
wants to merge 2 commits into from

Conversation

lee-chase
Copy link
Member

@lee-chase lee-chase commented Mar 4, 2024

An experiment to see what a SidePanel Modal might look like as a stylised version of the ComposedModal.

Following on from the AI work to create Web Component versions of @carbon/ibm-products/SidePanel and Tearsheet it appeared that SidePanel is similar to a ComposedModal in many ways.

This PR adds a single property kind to the Composed modal and uses styling SCSS to achieve most of the implementation. It is intended to spark a discussion about where the base SidePanel component should live and what it should look like.

Guidance on usage of SidePanel https://pages.github.ibm.com/cdai-design/pal/components/side-panel/usage

Changelog

Changed

  • ComposedModal properties and additional styling

@lee-chase lee-chase changed the title feat: side panel as modal kind feat: side panel as modal kind (proposal / talking point) Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2e05c75
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65e5f2cc9932bc00093a5be5
😎 Deploy Preview https://deploy-preview-15882--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

Thanks for opening these up! It will be great to have these to ground conversations as we discuss if these will be supported in Carbon. I think leaving them as drafts for now makes sense.

Related:

@tay1orjones
Copy link
Member

Hey thank you again for opening these up! Last week we had a team workshop to begin defining the process for contributions like this from other PALs into core. There will be more to come on that topic, but for now we identified these components as ones that need more evaluation before they're accepted. Right now that is probably going to be a coordinated effort in or around Q3.

Because of that I'm going to close these for now. We'll absolutely use them for discussions though and potentially reopen to save time on the implementation. Thanks again for kicking off this process and grounding these ideas in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants