-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript types to FilterableMultiSelect
#16147
Add TypeScript types to FilterableMultiSelect
#16147
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
// function handleOnOuterClick() { | ||
// handleOnMenuChange(false); | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guidari just want to double check this is no longer needed? Maybe we should add support for onChange to be logged to the actions pane in one of the storybook stories so this is testable in the deploy preview?
Hey @tay1orjones we don't need that anymore because we are passing here:
I added to the storybook |
@guidari awesome, lets ship it! |
…rbon into 12546-filterable-multi-select
5f35edd
Closes #12546
Changelog
New
useCombobox
from DownshiftChanged
Removed
<Downshift/>
componentTesting / Reviewing