Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript types to FilterableMultiSelect #16147

Merged

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Apr 8, 2024

Closes #12546

Changelog

New

  • Added useCombobox from Downshift

Changed

  • Converted FilterableMultiSelect file from JS to TSX.

Removed

  • Removed <Downshift/> component

Testing / Reviewing

  • Make sure the functionality remains the same.
  • Check if the types make sense and we didn't miss anything.
  • CI checks should pass

@guidari guidari requested a review from a team as a code owner April 8, 2024 12:47
@guidari guidari marked this pull request as draft April 8, 2024 12:47
@tay1orjones tay1orjones requested review from tay1orjones and removed request for andreancardona April 15, 2024 16:33
Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bfc1e6e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66290388a36f1a000873e7e7
😎 Deploy Preview https://deploy-preview-16147--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dc1be72
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/663bd5b26bed6900081bc8f2
😎 Deploy Preview https://deploy-preview-16147--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines 418 to 420
// function handleOnOuterClick() {
// handleOnMenuChange(false);
// }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guidari just want to double check this is no longer needed? Maybe we should add support for onChange to be logged to the actions pane in one of the storybook stories so this is testable in the deploy preview?

@guidari
Copy link
Contributor Author

guidari commented May 8, 2024

Hey @tay1orjones we don't need that anymore because we are passing here:

} = useSelection({
    disabled,
    initialSelectedItems,
    onChange,
    selectedItems: selected,
  });

I added to the storybook

Screenshot 2024-05-08 at 15 37 19

@guidari guidari requested a review from a team as a code owner May 8, 2024 18:38
@guidari guidari requested a review from alisonjoseph May 8, 2024 18:38
@tay1orjones
Copy link
Member

@guidari awesome, lets ship it! :shipit:

@tay1orjones tay1orjones removed the request for review from alisonjoseph May 8, 2024 19:11
@tay1orjones tay1orjones enabled auto-merge May 8, 2024 19:14
@tay1orjones tay1orjones added this pull request to the merge queue May 8, 2024
@guidari guidari removed this pull request from the merge queue due to a manual request May 8, 2024
@guidari guidari enabled auto-merge May 8, 2024 19:42
@guidari guidari added this pull request to the merge queue May 8, 2024
Merged via the queue into carbon-design-system:main with commit 5f35edd May 8, 2024
20 checks passed
@guidari guidari deleted the 12546-filterable-multi-select branch May 8, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to FilterableMultiSelect / use useCombobox instead of <Downshift> component
4 participants