Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Popover example to DataTable filtering story #16303

Merged
merged 8 commits into from
May 8, 2024
Merged

Added Popover example to DataTable filtering story #16303

merged 8 commits into from
May 8, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented May 2, 2024

Closes #15339

The idea wast to build a filter functionality off the Datatable so the users can grab the code as a template example to build their own filter.

Changelog

New

  • New template code in Datatable Filtering stories

Testing / Reviewing

  • Make sure the overview.mdx make it clear the step to implement the TableToolbarFilter.tsx
  • Test the Datatable Filtering stories

@guidari guidari requested a review from a team as a code owner May 2, 2024 14:58
@guidari guidari marked this pull request as draft May 2, 2024 14:59
@netlify Netlify
Copy link

netlify bot commented May 2, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit cfcbf2c
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/663b92d955caf40008ac5fdb
😎 Deploy Preview https://deploy-preview-16303--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari marked this pull request as ready for review May 2, 2024 15:15
tay1orjones
tay1orjones approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good! 🔥

Just a couple minor edits on the docs, otherwise this looks ready to merge to me.

packages/react/src/components/DataTable/DataTable.mdx Outdated Show resolved Hide resolved
packages/react/src/components/DataTable/DataTable.mdx Outdated Show resolved Hide resolved
packages/react/src/components/DataTable/DataTable.mdx Outdated Show resolved Hide resolved
packages/react/src/components/DataTable/DataTable.mdx Outdated Show resolved Hide resolved
packages/react/src/components/DataTable/DataTable.mdx Outdated Show resolved Hide resolved
alisonjoseph

This comment was marked as outdated.

Sign in to view

alisonjoseph
alisonjoseph requested changes May 7, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just went to close my preview window and realized the popover colors are different for settings and filter. I think settings is correct, but we should check with design if not sure. Functionality and docs look great though 🔥
Screenshot 2024-05-07 at 7 47 11 AM
Screenshot 2024-05-07 at 7 47 33 AM

@guidari
Copy link
Contributor Author

guidari commented May 7, 2024

Sorry, just went to close my preview window and realized the popover colors are different for settings and filter. I think settings is correct, but we should check with design if not sure. Functionality and docs look great though 🔥

Ohh! Good catch. I'm gonna take a look and check with design if they want to change something!

@guidari guidari requested a review from thyhmdo May 7, 2024 13:48
@thyhmdo
Copy link
Member

thyhmdo commented May 7, 2024

Good catch @alisonjoseph yeah the color should be the same with the settings' popover, or one layer up from it.
I also noticed another thing is that these two buttons can be opened at the same time? Is there a way to close one popover if the user chooses to open another one?

Screen.Recording.2024-05-07.at.1.21.48.PM.mov

@guidari guidari requested a review from a team as a code owner May 7, 2024 20:27
@guidari
Copy link
Contributor Author

guidari commented May 8, 2024

Good catch @alisonjoseph yeah the color should be the same with the settings' popover, or one layer up from it. I also noticed another thing is that these two buttons can be opened at the same time? Is there a way to close one popover if the user chooses to open another one?

Fixed @thyhmdo ! Looks like the Popover gets an error when clicks on an OverflowMenu, which results in the state being kept open instead of closing it.
I can open an issue to track that.

@guidari guidari requested a review from alisonjoseph May 8, 2024 12:57
alisonjoseph
alisonjoseph approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Screenshot 2024-05-08 at 8 00 35 AM

alisonjoseph
alisonjoseph requested changes May 8, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Percy caught an issues with different themes

@guidari guidari enabled auto-merge May 8, 2024 16:02
@guidari guidari requested a review from alisonjoseph May 8, 2024 16:02
alisonjoseph
alisonjoseph approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@guidari guidari added this pull request to the merge queue May 8, 2024
Merged via the queue into carbon-design-system:main with commit d4a3f7e May 8, 2024
20 checks passed
@guidari guidari deleted the 15339-datatable branch May 8, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@thyhmdo thyhmdo Awaiting requested review from thyhmdo

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Popover example to DataTable filtering story
4 participants
@guidari @thyhmdo @alisonjoseph @tay1orjones