fix: export props for components #16455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
May 21, 2024
Comment on lines
+8
to
+9
| import { type GridProps } from './GridTypes'; | ||
| export { type GridProps }; |
There was a problem hiding this comment.
Could this be one line?
Suggested change
| import { type GridProps } from './GridTypes'; | |
| export { type GridProps }; | |
| export { type GridProps } from './GridTypes'; |
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit May 21, 2024
96214a9
20 checks passed
|
Hey there! v11.58.0 was just released that references this issue/PR. |
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16364 Accordion
Closes #16366 Structured List
Closes #16367 Button
Closes #16368 Button
Closes #16369 Column
Closes #16370 Dropdown
Closes #16371 FormLabel
Closes #16372 Grid
Exporting the typescript props for the above mentioned components as part of typescript adoption
(This PR is mentioned as 1, as we have more components where props needs to be exported so there will be more PRs regarding this)
Changelog
Changed
.tsxfiles if not doneindex.tsand exporting them explicitly so that users can import them directly with the component.Testing / Reviewing
No changes to the component, so new testing observations.