Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add floating ui to dropdown #16492

Merged
merged 21 commits into from
Jun 21, 2024
Merged

feat: Add floating ui to dropdown #16492

merged 21 commits into from
Jun 21, 2024

Conversation

preetibansalui
Copy link
Contributor

Closes #15865

Implement Floating UI in Dropdown

Changed

Implement floating ui in Dropdown

@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f070c59
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66751ec46fa1e00008bd44cc
😎 Deploy Preview https://deploy-preview-16492--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2nikhiltom 2nikhiltom changed the title feat: implement floating ui to dropdown feat: Add floating ui to dropdown May 21, 2024
@preetibansalui preetibansalui mentioned this pull request May 22, 2024
Merged
@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f070c59
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66751ec40e72b90008da0e5b
😎 Deploy Preview https://deploy-preview-16492--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AustinGitHub
Copy link
Contributor

Hi @preetibansalui do you know what the status of this PR is and ETA of it being merged in? I am told that this will resolve an issue with the scrolling issue when we use a dropdown that would resolve an issue like this #7565

Thanks!

@preetibansalui preetibansalui marked this pull request as ready for review June 5, 2024 10:10
@preetibansalui preetibansalui requested review from a team as code owners June 5, 2024 10:10
riddhybansal
riddhybansal requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need an autoalign prop in this ? Autoalignment should not be conditional in case of dropdown. Floating UI should be added to it by default. @tay1orjones What are your views on this ?

@preetibansalui
Copy link
Contributor Author

Do we really need an autoalign prop in this ? Autoalignment should not be conditional in case of dropdown. Floating UI should be added to it by default. @tay1orjones What are your views on this ?

As discussed on Slack, we are keeping autoAlign Prop as of now.

riddhybansal
riddhybansal approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM !!!

alisonjoseph
alisonjoseph approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Do we want to set autoAlign to true in all of the Modal stories and not just the Playground?

@preetibansalui
Copy link
Contributor Author

This LGTM! Do we want to set autoAlign to true in all of the Modal stories and not just the Playground?

I think it would be better if we remove it from here, As we already have a separate issue where we will be creating stackblitz examples for all related issue. I will remove it, Thanks for bringing this up.

tay1orjones
tay1orjones requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super good, just a couple small things

packages/react/src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
@preetibansalui
Copy link
Contributor Author

This looks super good, just a couple small things

Thanks Taylor for the amazing suggestions, just pushed the changes as suggested. Please review the PR again.

@tay1orjones tay1orjones enabled auto-merge June 20, 2024 18:30
@tay1orjones tay1orjones added this pull request to the merge queue Jun 21, 2024
Merged via the queue into carbon-design-system:main with commit 854c889 Jun 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidari guidari guidari left review comments

@riddhybansal riddhybansal riddhybansal approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add floating-ui to @carbon/react Dropdown
7 participants
@preetibansalui @AustinGitHub @alisonjoseph @tay1orjones @riddhybansal @guidari @2nikhiltom