Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): fix background colour for overflow nav button #16505

Closed

Conversation

divya-281
Copy link
Contributor

@divya-281 divya-281 commented May 20, 2024

Closes #

Screenshot 2024-05-20 at 7 04 19 PM Screenshot 2024-05-20 at 7 04 44 PM

Changelog

Changed
Left scroll button:
Screenshot 2024-05-20 at 7 05 26 PM

Right scroll button:
Screenshot 2024-05-20 at 7 05 09 PM

The disabled token is already apprearing here:
Screenshot 2024-05-20 at 6 18 23 PM

Testing / Reviewing

Start story book with yarn storybook
Narrow your screen so that the scrollable button is visible

Copy link
Contributor

github-actions bot commented May 20, 2024

Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


1 out of 2 committers have signed the DCO.
✅ (divya-281)[https://github.com/divya-281]
@divya G
Divya G seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented May 20, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b5d4462
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/664b56e73e649000088ada7e
😎 Deploy Preview https://deploy-preview-16505--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@divya-281
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@divya-281
Copy link
Contributor Author

recheck

feat(tabs): fix next overflow nav button

feat(tabs): take fade out from scrollable button

feat(tabs): take fade out from scrollable button
@divya-281 divya-281 force-pushed the fix-left-overflow-nav branch from 323e223 to 2ed7440 Compare May 20, 2024 13:56
@divya-281 divya-281 closed this May 20, 2024
Copy link

netlify bot commented May 20, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b5d4462
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/664b56e74d38270008105a80
😎 Deploy Preview https://deploy-preview-16505--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant