-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): add toContainAStory assertion to visitStory(new) #16582
test(e2e): add toContainAStory assertion to visitStory(new) #16582
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Gururajj77
LGTM! I think we just have to fix the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor things I saw
@Gururajj77 in an effort to get this passing, I've added a few things:
Two things I left in that I think we should defer to another issue/pr:
Could you pull this down locally and run the tests? Let me know if you still see any failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
2820f64
Continued PR of #16132
updated tests with right storybook id for prop
avt
andvrt
testsChangelog
Changed
FluidTextInput
,Tag
, andUIShell
Testing / Reviewing
Run
avt
andvrt
tests.