Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): add toContainAStory assertion to visitStory(new) #16582

Merged
merged 22 commits into from
Aug 23, 2024

Conversation

Gururajj77
Copy link
Contributor

Continued PR of #16132

updated tests with right storybook id for prop avt and vrt tests

Changelog

Changed

  • updated tests with right storybook id for FluidTextInput, Tag, and UIShell

Testing / Reviewing

Run avt and vrt tests.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 6056e1d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66c8d3cfe01e0b0008dba1da
😎 Deploy Preview https://deploy-preview-16582--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 6056e1d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66c8d3cfe16b1900084e920c
😎 Deploy Preview https://deploy-preview-16582--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 self-assigned this May 28, 2024
Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gururajj77

LGTM! I think we just have to fix the CI

@tay1orjones tay1orjones self-assigned this Jun 19, 2024
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor things I saw

e2e/components/UIShell/UIShell-test.e2e.js Outdated Show resolved Hide resolved
@tay1orjones tay1orjones mentioned this pull request Aug 20, 2024
@tay1orjones tay1orjones requested a review from a team as a code owner August 23, 2024 02:52
@tay1orjones tay1orjones self-requested a review August 23, 2024 02:52
@tay1orjones
Copy link
Member

@Gururajj77 in an effort to get this passing, I've added a few things:

Two things I left in that I think we should defer to another issue/pr:

  • DatePicker @avt-advanced-states open test skipped due to color contrast a11y failure (I'm not confident this is an actual failure, but I'm not sure why it's failing)
  • Skipped DataTable's @avt-advanced-states with-radio-expansion test due to an odd failure where the id's on rows are not correct on the dynamic story. This state is already covered though by the expansion-related tests

Could you pull this down locally and run the tests? Let me know if you still see any failures.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tay1orjones tay1orjones added this pull request to the merge queue Aug 23, 2024
Merged via the queue into carbon-design-system:main with commit 2820f64 Aug 23, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants