Adds horizontal variant in CheckboxGroup #16583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Nice work, @2nikhiltom! 🔥
Just a small question:
Would it be possible to add a prop for a horizontal checkbox? This way, we could include it in the Playground state also and better interact with the horizontal checkbox in different states (warning, error, disabled, etc).
2nikhiltom
added
status: WIP 👩💻
and removed
status: ready for review 👀
status: visual review 🔍
labels
|
@Kritvi-bhatia17 ! Yeah good catch |
Kritvi-bhatia17
approved these changes
May 28, 2024
alisonjoseph
requested changes
May 28, 2024
alisonjoseph
approved these changes
May 28, 2024
|
Awesome!! Thanks for looking into this @alisonjoseph 💯 |
2nikhiltom
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit May 28, 2024
89907da
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16486
Adds horizontal variant in CheckboxGroup
Changelog
New
orientationoptional prop (reference from RadioButtonGroup)orientationto playgroundorientationis set tohorizontalThe parent
<fieldset>usesdisplay: flexfor horizontal alignment, causing issues with the alignment of the warning messages.To avoid breaking changes in the DOM structure, class usage and styles , I have applied
position: absoluteto the warning message<div>to ensure it appears correctly below the<fieldset>.Testing / Reviewing
Open deploy preview and navigate to CheckboxGroup story to verify if horizontal variant is working good.
Also verify
orientationprop working in playground