Added Floating UI to MultiSelect and FilterableMultiSelect
#16689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
riddhybansal
approved these changes
Jun 6, 2024
tay1orjones
reviewed
Jun 13, 2024
packages/react/src/components/MultiSelect/MultiSelect.stories.js
Outdated
Show resolved
Hide resolved
tay1orjones
approved these changes
Jun 20, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 21, 2024
fb2dfdb
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16507
Added Floating UI to
MultiSelectandFilterableMultiSelect. To work the test we had to add theactto wait for the floating to position.Testing / Reviewing
divfrom Default and Filterable stories.