fix(ComposedModal): removed extra tooltip for close icon #16728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
nandininarayanofficial
force-pushed
the
bugfix/16724-hovering-over-close-in-composed-model
branch
from
5387e92 to
babdfd4
Compare
guidari
approved these changes
Jun 11, 2024
tay1orjones
approved these changes
Jun 11, 2024
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
|
@nandininarayanofficial this looks good to merge but needs the all contributors regenerated to resolve the merge conflict. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nandininarayanofficial
force-pushed
the
bugfix/16724-hovering-over-close-in-composed-model
branch
from
d044f42 to
8996f00
Compare
|
@tay1orjones I resolved the conflicts, please review, Thanks! |
README.md
Outdated
| @@ -291,7 +291,10 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our | |||
| <td align="center"><a href="https://github.com/aninaantony"><img src="https://avatars.githubusercontent.com/u/164350784?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Anina Antony</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=aninaantony" title="Code">💻</a></td> | |||
| <td align="center"><a href="https://github.com/ahmedsemih"><img src="https://avatars.githubusercontent.com/u/102798814?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Ahmed Semih Erkan</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=ahmedsemih" title="Code">💻</a></td> | |||
| <td align="center"><a href="https://github.com/ychavoya"><img src="https://avatars.githubusercontent.com/u/7907338?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Yael Chavoya</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=ychavoya" title="Code">💻</a></td> | |||
| <td align="center"><a href="https://github.com/Kilian-Collender"><img src="https://avatars.githubusercontent.com/u/37899503?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Kilian Collender</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Kilian-Collender" title="Code">💻</a></td> | |||
| <td align="center"><img src="https://avatars.githubusercontent.com/u/37899503?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Kilian Collender</b></sub><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=Kilian-Collender" title="Code">💻</a></td> | |||
There was a problem hiding this comment.
Hey, looks like you removed the anchor tag from name and picture of this contributor.
preetibansalui
requested changes
Jun 12, 2024
|
@preetibansalui thank you for noticing this, fixed it, please review! |
preetibansalui
approved these changes
Jun 13, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 14, 2024
af09913
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16724
Removed additional close tooltip for ComposedModel
Changed
Removed title value from close icon
Updated ComposedModal-test.js
Testing / Reviewing
ComposedModal