fix: filterable multiselect search issue #16729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
riddhybansal
force-pushed
the
Filterable_Multiselect_search_issue
branch
from
7b11747 to
1c76d24
Compare
riddhybansal
added
status: ready for review 👀
and removed
status: failing CI 🙅♂️
labels
alisonjoseph
approved these changes
Jun 17, 2024
guidari
approved these changes
Jun 18, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 19, 2024
763e480
22 checks passed
|
Hey there! v11.60.0 was just released that references this issue/PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16145
When using a FilterableMultiSelect inside of a Tab/TabPanel and you use the search bar to filter the list, if there is a scroll bar and you use the mouse to scroll the list, the search term clears out, just as if you were to click outside of the FilterableMultiSelect. Doing the same while not in a Tab/TabPanel does NOT clear the search term (as expected and desired).
Changelog
New
Testing / Reviewing
Select the filterable multi select inside the Test story, search on aa and then try to scroll the list by scrollbar the search field should not get empty
Try clicking outside anywhere on the screen when filterable multiselect is opened, it should work as intended.