Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add figma code connect #16730

Merged
merged 2 commits into from
Jun 12, 2024
Merged

feat: add figma code connect #16730

merged 2 commits into from
Jun 12, 2024

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jun 10, 2024

Ref #16273
Closes #16561

Changelog

New

  • add @figma/code-connect
  • add github action to publish code connect whenever a *.figma.tsx file is added/updated
  • add FIGMA_ACCESS_TOKEN to secrets
  • add figma.config.json config
  • add code-connect/README.md file
  • exclude *.figma.tsx files from tsconfig
  • Connect components
    • Accordion
    • Breadcrumb
    • Button
    • Checkbox
    • CodeSnippet
    • ContainedList
    • ContentSwitcher
    • Dropdown
    • Link
    • Notification
    • NumberInput
    • Tabs
    • Toggle

*will add additional components in separate PRs

* chore: update gitignore

* feat: add figma code connect

* chore: update readme

* feat(code-connect): update Link and Notification

* feat: code connect updates

* chore: update disclaimer text

* feat: add checkbox

* feat: contentswitcher

* feat: add breadcrumb checkbox and grid

* feat: codesnippet

* feat: wip tooltip and contained list

* chore: update to 0.1.2

* chore: add code comments to accordion

* docs: update readma

* feat(code-connect): connect toggle

* feat(code-connect): connect NumberInput

* chore: add basic config file

* chore: ignore ts and exclude from ts build

* chore: update config file

* chore: update readme

* chore: fix versions from merge conflict

* chore: yarn dedupe

* chore: fix yarn

* chore: yarn

* chore: yarn
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 36ee89e
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66670cb839834f00098d714a
😎 Deploy Preview https://deploy-preview-16730--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4ea6c8c
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66670ba403e7590008a34905
😎 Deploy Preview https://deploy-preview-16730--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 36ee89e
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66670cb8f223590008026bd0
😎 Deploy Preview https://deploy-preview-16730--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review June 10, 2024 17:43
@alisonjoseph alisonjoseph requested review from a team as code owners June 10, 2024 17:43
@alisonjoseph alisonjoseph changed the title feat: add figma code connect (#16348) feat: add figma code connect Jun 10, 2024
name: Code Connect
runs-on: ubuntu-latest
steps:
- run: npx figma connect publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see FIGMA_ACCESS_TOKEN was added to the repo action secrets 👍

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚢 🚀

@guidari guidari added this pull request to the merge queue Jun 12, 2024
Merged via the queue into main with commit 47b909e Jun 12, 2024
22 checks passed
@guidari guidari deleted the code-connect branch June 12, 2024 17:04
Copy link
Contributor

The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page.

@dlavrenuek
Copy link

dlavrenuek commented Jun 21, 2024

@alisonjoseph is it correct that @figma/code-connect is listed as a production dependency instead of devDependency? The described functionality does not seem to be added to production code when @carbon/react is included in a project.

@alisonjoseph
Copy link
Member Author

@dlavrenuek you're correct, updated here #16834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figma Code Connect: Set up CI / github actions to automatically publish updates
4 participants