fix: popover closing issue when clicked on overflow menu #16792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
reviewed
Jun 17, 2024
packages/react/src/components/OverflowMenu/OverflowMenu-test.js
Outdated
Show resolved
Hide resolved
guidari
approved these changes
Jun 26, 2024
tay1orjones
approved these changes
Jun 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jun 26, 2024
697684e
22 checks passed
|
this fix actually broken our application using the OverflowMenu but there is application logic in onClick property for the OverflowMenu, and the onClick callback will also update the other property for the OverflowMenu, then the OverflowMenu open state will be messed up, the menu body can not be opened properly. Add the event.stopPropagation() back or use a timeout in our onClick logic can work around this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16357
Popover doesn't close when OverflowMenu is Clicked. The issue is caused after this PR . event.stopPropagation was added to fix calling of handleOnClick twice. The issue doesnot persist now even after removing event.stopPropagation. To ensure the previous issue is not encountered after this PR, test cases has been added.
Changelog
Removed
Testing / Reviewing
Go to storybook->popover->test popover should get closed after clicking on overflowMenu or anywhere else.
Test the functioning of overflow menu stories also , it should work as intended and click event should not be called twice.