Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): change react-router example to use UI Shell #16817

Merged

Conversation

ychavoya
Copy link
Contributor

Closes #14897

Updated the react-router example to use Carbon 11 and provided examples with various UI Shell components

Changelog

Changed

  • react-router example now uses Carbon 11 (@carbon/react)
  • example no longer throws an error when running yarn start
  • examples changed to demonstrate usage with Buttons, Header navigation, Breadcrumbs, etc

Testing / Reviewing

  • Go to the path of the example packages/react/examples/react-router
  • Follow the instructions in the README (yarn install && yarn start)
  • The example should open and you should be able to interact with it

@ychavoya ychavoya requested a review from a team as a code owner June 18, 2024 18:56
@ychavoya ychavoya requested review from alisonjoseph and guidari June 18, 2024 18:56
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c3f195b
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/668599c544996f0008f03c03
😎 Deploy Preview https://deploy-preview-16817--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c3f195b
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/668599c51c49730008716baa
😎 Deploy Preview https://deploy-preview-16817--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! 🙌

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@alisonjoseph alisonjoseph added this pull request to the merge queue Jul 1, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jul 1, 2024
* docs(examples): update react-router example to use carbon v11

* docs(examples): change react-router example to use UI Shell

* chore(all-contributors): update contributors list

* test(examples): fix test for react-router example
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2024
@tay1orjones tay1orjones enabled auto-merge July 3, 2024 18:34
@tay1orjones tay1orjones added this pull request to the merge queue Jul 3, 2024
Merged via the queue into carbon-design-system:main with commit e8dab24 Jul 3, 2024
22 checks passed
@ychavoya ychavoya deleted the update-router-example branch July 4, 2024 01:31
@carbon-automation
Copy link
Contributor

Hey there! v11.61.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update react-router example to use v6
3 participants