Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons-react): remove style attribute #16845

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jun 21, 2024

Closes carbon-design-system/carbon-website#4096

Changelog

Removed

  • remove style prop

Testing / Reviewing

Images should look the same

@alisonjoseph alisonjoseph marked this pull request as ready for review June 21, 2024 16:51
@alisonjoseph alisonjoseph requested review from laurenmrice and a team as code owners June 21, 2024 16:51
Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 977e2be
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6675af39685e6a000879b782
😎 Deploy Preview https://deploy-preview-16845--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 977e2be
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6675af39cd8f4400085a18ef
😎 Deploy Preview https://deploy-preview-16845--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph added this pull request to the merge queue Jun 25, 2024
Merged via the queue into carbon-design-system:main with commit 435f214 Jun 25, 2024
22 checks passed
@alisonjoseph alisonjoseph deleted the icon-fix branch June 25, 2024 16:17
@Kritvi-bhatia17
Copy link
Contributor

Hi @alisonjoseph! Thanks for fixing that, it looks good now. 🎉
However, I noticed the alignment is a bit off, and I've noticed this issue on the 'Pictograms' page as well. Before creating an issue, I wanted to confirm with you: is it feasible to fix that alignment?
Screenshot 2024-07-08 at 10 12 22 PM

@alisonjoseph
Copy link
Member Author

@Kritvi-bhatia17 yes we can fix that if you open an issue

@Kritvi-bhatia17
Copy link
Contributor

Sorry, I just realized I commented on the wrong PR by mistake. I meant to comment on this one. However, I have opened an issue for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Icon search goes black when searching specific terms
6 participants