Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dialog): remove unneeded wicg-inert polyfill #16907

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jul 2, 2024

This came up in slack - this polyfill is no longer needed. I also modified the dialog export to be unstable__Dialog. This isn't included in storybook, and it isn't exported from the root. It's not intended to be used yet but we hadn't formally marked the export as unstable.

Changelog

Changed

  • remove wicg-inert package
  • modify Dialog to unstable__Dialog

Testing / Reviewing

  • If you want to validate the dialog changes, uncomment the 'includeStories' line in the dialog story file and spin up storybook locally. The stories will still work and should behave as they did before.

@tay1orjones tay1orjones requested a review from a team as a code owner July 2, 2024 18:50
@tay1orjones tay1orjones self-assigned this Jul 2, 2024
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b19ac9a
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66844c03a1edd500080c0607
😎 Deploy Preview https://deploy-preview-16907--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b19ac9a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66844c03a4642e00088453f6
😎 Deploy Preview https://deploy-preview-16907--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones added this pull request to the merge queue Jul 3, 2024
Merged via the queue into carbon-design-system:main with commit b780e77 Jul 3, 2024
22 checks passed
@tay1orjones tay1orjones deleted the remove-wicg-inert branch July 3, 2024 18:03
@carbon-automation
Copy link
Contributor

Hey there! v11.61.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants