You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#15965 attempted to prevent table row hover states from affecting links within nested Toggletips; however, the solution was incomplete and caused a style regression.
❌ Before
Toggletip-hover-before.mov
As demonstrated above:
When a Toggletip is adjacent to a link, the intended hover styles are no longer applied to the link (i.e., the link color does not change when the row is hovered on).
When a Toggletip is in an adjacent cell, the row hover state works, but it affects the Toggletip's link.
📝 Changelog
Changed
Modify CSS selector to only change a link's color when it is a child of a table cell but not within a Toggletip.
Changes:
- Improve CSS selector which modifies inline links when their
parent row is hovered over. Isolate the color change from
affecting links within an adjacent cell's toggletip.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alisonjoseph
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
#15965 attempted to prevent table row hover states from affecting links within nested
Toggletips; however, the solution was incomplete and caused a style regression.❌ Before
Toggletip-hover-before.mov
As demonstrated above:
Toggletipis adjacent to a link, the intended hover styles are no longer applied to the link (i.e., the link color does not change when the row is hovered on).Toggletipis in an adjacent cell, the row hover state works, but it affects theToggletip's link.📝 Changelog
Changed
Toggletip.✅ After
Toggletip-hover-after.mov
🧪 Testing / Reviewing
DataTablestorybook example: carbon-datatable-toggletip-story.js