Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code-connect): connect ContainedList and cleanup other files #16929

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jul 9, 2024

Closes #16656

Changelog

New

  • Connect ContainedList, ContainedListItem

Changed

  • Cleanup other component files, switch to spread syntax for props where possible
  • Remove code comments (doesn't scale well with nested components)

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit d31db66
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/668d55d0d40b7c00083fd410
😎 Deploy Preview https://deploy-preview-16929--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit d31db66
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/668d55d0c81b330008c80892
😎 Deploy Preview https://deploy-preview-16929--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review July 9, 2024 15:30
@alisonjoseph alisonjoseph requested a review from a team as a code owner July 9, 2024 15:30
@alisonjoseph alisonjoseph changed the title Code connect update feat(code-connect): connect ContainedList and cleanup other files Jul 9, 2024
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ce0a0bc
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/668e8f7abb852e0008172a90
😎 Deploy Preview https://deploy-preview-16929--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ce0a0bc
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/668e8f7a858a5600082df199
😎 Deploy Preview https://deploy-preview-16929--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph merged commit f7f4baa into carbon-design-system:main Jul 10, 2024
22 checks passed
@alisonjoseph alisonjoseph deleted the code-connect-update branch July 10, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Connect : ContainedList, ContainedListItem
3 participants