-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accordion): support nested accordion #16933
feat(accordion): support nested accordion #16933
Conversation
All contributors have signed the DCO. |
42d4476
to
39c47b4
Compare
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
39c47b4
to
3d7dbd2
Compare
I have read the DCO document and I hereby sign the DCO. |
Signed-off-by: Ahmed Alsinan <[email protected]>
3d7dbd2
to
9d38ef3
Compare
Hey @tekno0ryder ! thanks for your contribution, could you please setup a test story, that can be excluded later if we approve it?? |
Hi! please find preview story here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the contribution! 🚀
Please don't forget to remove the Test stories before merging it, since it's something that Carbon don't formally support.
@alisonjoseph One more review pls 👀 🙏 |
d6b01b7
Closes #16732
Support rare case of using nested accordions
Changelog
Changed
Testing / Reviewing
Screen.Recording.2024-07-09.at.11.45.40.PM.mov