Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(accordion): support nested accordion #16933

Merged

Conversation

tekno0ryder
Copy link
Contributor

Closes #16732

Support rare case of using nested accordions

Changelog

Changed

  • Changed active css selector from descendant combinator that targets all descendants regardless of their level to child combinator (>) that targets only the direct children.

Testing / Reviewing

  • Unit test: Expanding parent shouldn't expand children accordion + Expand children works
  • Video
Screen.Recording.2024-07-09.at.11.45.40.PM.mov

Copy link
Contributor

github-actions bot commented Jul 9, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@tekno0ryder tekno0ryder force-pushed the feat/nested-accordion branch from 42d4476 to 39c47b4 Compare July 9, 2024 21:27
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 42d4476
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/668daa42a136e60008551a88
😎 Deploy Preview https://deploy-preview-16933--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 42d4476
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/668daa42c81b330008f5d5ba
😎 Deploy Preview https://deploy-preview-16933--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ab18d08
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66aaa36692a7e90008ee999e
😎 Deploy Preview https://deploy-preview-16933--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ab18d08
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66aaa3660e8bf30008ec09d9
😎 Deploy Preview https://deploy-preview-16933--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tekno0ryder tekno0ryder force-pushed the feat/nested-accordion branch from 39c47b4 to 3d7dbd2 Compare July 9, 2024 21:34
@tekno0ryder
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@tekno0ryder tekno0ryder force-pushed the feat/nested-accordion branch from 3d7dbd2 to 9d38ef3 Compare July 9, 2024 21:39
@tekno0ryder tekno0ryder marked this pull request as ready for review July 10, 2024 13:30
@tekno0ryder tekno0ryder requested a review from a team as a code owner July 10, 2024 13:30
@Gururajj77
Copy link
Contributor

Hey @tekno0ryder ! thanks for your contribution, could you please setup a test story, that can be excluded later if we approve it??

@tekno0ryder
Copy link
Contributor Author

Hey @tekno0ryder ! thanks for your contribution, could you please setup a test story, that can be excluded later if we approve it??

Hi! please find preview story here

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution! 🚀

Please don't forget to remove the Test stories before merging it, since it's something that Carbon don't formally support.

@tekno0ryder
Copy link
Contributor Author

@alisonjoseph One more review pls 👀 🙏

@tay1orjones tay1orjones added this pull request to the merge queue Jul 31, 2024
Merged via the queue into carbon-design-system:main with commit d6b01b7 Jul 31, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Child accordion's expand/collapse not working
5 participants